Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode tests #359

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Encode tests #359

wants to merge 5 commits into from

Conversation

bconn98
Copy link
Collaborator

@bconn98 bconn98 commented Mar 3, 2024

Increase test coverage of the encode module.

Hard code the time string created by the json encoder for tests

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.88%. Comparing base (f688e38) to head (6dcf08c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
+ Coverage   63.42%   64.88%   +1.46%     
==========================================
  Files          25       25              
  Lines        1572     1572              
==========================================
+ Hits          997     1020      +23     
+ Misses        575      552      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bconn98 bconn98 force-pushed the encode_tests branch 8 times, most recently from 56728ac to 7a75209 Compare March 3, 2024 19:52
@bconn98
Copy link
Collaborator Author

bconn98 commented Mar 3, 2024

Now that once_cell is being pulled into the standard library in 1.70, we can bump to that and utilize the new standardized interface. Or, I can make similar modifications to the once_cell version to allow for dependency injection. @estk I'll defer to you on that decision. I know 1.70 is only 8 months old.

@estk
Copy link
Owner

estk commented Mar 3, 2024

Ya lets stick to 1.69 for now

@bconn98
Copy link
Collaborator Author

bconn98 commented Mar 4, 2024

@estk Swapped to OnceCell instead. I kept the version using the standard library in a separate branch that I'll submit towards the middle of the year when we look at moving up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants