Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to edition 2018, deps and docs #108

Merged
merged 7 commits into from
Dec 17, 2019
Merged

Update to edition 2018, deps and docs #108

merged 7 commits into from
Dec 17, 2019

Conversation

estk
Copy link
Owner

@estk estk commented Nov 29, 2019

Closes #105
Closes #106

src/append/rolling_file/mod.rs Show resolved Hide resolved
src/priv_file.rs Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@estk
Copy link
Owner Author

estk commented Dec 3, 2019

@calvinbrown085 I would love a review on this.

Copy link
Contributor

@calvinbrown085 calvinbrown085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estk Now that we are on 2018, can we get rid of some of the extern crate * lines in lib.rs ?

https://github.com/estk/log4rs/blob/master/src/lib.rs#L170

For example:
extern crate arc_swap;
or
extern crate log;

If we aren't using any macros from the library I believe we can get rid of them, but I could be wrong there :)

@calvinbrown085
Copy link
Contributor

@estk I think my only question was #108 (review)
Otherwise lgtm!

@estk
Copy link
Owner Author

estk commented Dec 12, 2019

@calvinbrown085 thanks for the review! Removing the extern crate stuff is a little harder than I thought, but its in the works. Thanks again!

@calvinbrown085
Copy link
Contributor

@estk You're welcome!

@calvinbrown085
Copy link
Contributor

@estk Anything I can help out with here?

@estk
Copy link
Owner Author

estk commented Dec 17, 2019

@calvinbrown085 I'm slammed with the holidays coming up. I'm inclined to merge this as is and open an issue to remove the extern crate stuff. How does that sound? Also, if you feel like working on the extern crate work I would love that!

@estk
Copy link
Owner Author

estk commented Dec 17, 2019

#113 addresses the extern crate stuff, not sure its ready to be shipped though

@calvinbrown085
Copy link
Contributor

@estk Yeah totally understandable! I can help with the extern crate stuff. I think this is ready to 🚢

@calvinbrown085
Copy link
Contributor

Also, apologies if that came off as forceful!

@estk estk merged commit 55991a0 into master Dec 17, 2019
@estk estk deleted the edition branch December 17, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change to rust 2018 Badges in readme
2 participants