-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project-based Workflow #651
Draft
Felixmil
wants to merge
48
commits into
new-project-structure
Choose a base branch
from
implement-project
base: new-project-structure
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n without inducing breaking changes + usethis::use_package("lifecycle") + update tests accordingly + add test for deprecation
+ devtools::document()
+ remove names of internal collaborators
…msFile-to-modelParamsFile # Conflicts: # NEWS.md # R/project-configuration.R # inst/extdata/examples/TestProject/Configurations/Populations.xlsx # inst/extdata/examples/TestProject/ProjectConfiguration.xlsx # tests/testthat/test-utilities-population.R
… that depends on environment
+ use projectConfiguration$populationsCSV to locate population CSV files to read + add test to make sure all test scenarios can be properly created
…msFile-to-modelParamsFile # Conflicts: # NEWS.md
…nfigurations, scenarios, simulationResults) + tests
This was
linked to
issues
May 15, 2024
Felixmil
changed the title
Implement project
Initial implementation of project base workflow
May 15, 2024
# Conflicts: # R/project-configuration.R # R/scenario.R # R/utilities-project-configuration.R # inst/extdata/examples/TestProject/ProjectConfiguration.xlsx # man/ExportConfiguration.Rd # man/ProjectConfiguration.Rd # tests/testthat/helpers.R # tests/testthat/test-utilities-population.R # tests/testthat/test-utilities-project-configuration.R # tests/testthat/test-utilities-scenarios.R
+ add related test
Small fixes
+ test + documentation
+ add method for nice printing of simulationTime objects
+ scenario$configuration is now a copy of configurations$scenarios + rename scenarioConfigurationData argument to scenarioConfiguration
+ replace purrr:map(names(... by purrr:imap(...
+ refactor and document + remove legacy code that was re-implemented in new framework + relocate "utils" function in appropriate files
+devtools::document()
Felixmil
changed the title
Initial implementation of project base workflow
Project-based Workflow
Jul 2, 2024
Felixmil
force-pushed
the
implement-project
branch
from
July 30, 2024 10:30
dace2dc
to
07bfb1e
Compare
# Conflicts: # R/project-configuration.R
… into implement-project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Workflow Preview
Created on 2024-05-06 with reprex v2.1.0