[flash] Compute size correctly for > 256MBit (IDFGH-8063) #9566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
4 tasks
|
@igrr I closed my similar PR you commented on. I think this one is better since you established that this scheme is common amongst chip vendors. |
|
any update on this ? @Alvin1Zhang |
espressif-bot
added
Resolution: NA
|
Woohoo! |
|
@mythbuster5 is this going to be backported to 4.4? |
espressif-bot
pushed a commit
that referenced
this pull request
Mar 9, 2023
…er large size memory, Closes #9566
espressif-bot
pushed a commit
that referenced
this pull request
Mar 22, 2023
…er large size memory, Closes #9566
johnboiles
pushed a commit
to sindarin-inc/esp-idf
that referenced
this pull request
Mar 24, 2023
…er large size memory, Closes espressif#9566
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a generic replacement for
#9381
The computation of the size seems to be done by considering the byte being decimal and not hex.