-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(esptool): merge_bin CMake target (IDFGH-12541) #13546
Conversation
👋 Hello nebkat, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Hello @nebkat and thank you for your contribution! |
@Honza0297 I haven't spent enough time around idf.py internals and the CMake system so I might not fully understand, but: My main requirement is to be able to generate the merged binary without having to specify It does feel like something that fits in to the CMake system since it is generating binaries, and this would allow it to be used from IDE (I am successfully using CMake in CLion). I don't have any such use case right now but it would also allow for other targets to depend on the merged binary file, maybe for some customized release system. |
I understand your main requirement - both approaches (CMake and Python) will solve it. |
We will add a cmake target as well. |
No description provided.