Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ulp_adc_deinit() API to fix ADC1 handle leakage (IDFGH-11673) #12785

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

kutukvpavel
Copy link
Contributor

Fix for #12766. Also restructured error handling in ulp_adc_init(...) so that it returns an error code instead of calling abort() from ESP_ERROR_CHECK(...).
Tested against ulp_riscv_adc example (deep sleep case) as well as our own custom app (light sleep case).

P.S. Right now ulp_adc driver is remarkably similar to oneshot driver itself, it mostly duplicates configuration API, introducing little new functionality. While I think this PR should be merged and backported to v5.1 branch ASAP to enable customers (like us) to use ULP ADC with Light Sleep, it's probably worth integrating ULP-related initialization code into oneshot driver itself in future releases. After all, adc_oneshot_unit_init_cfg_t::ulp_mode is already there.

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Dec 12, 2023

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello kutukvpavel, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 8596d46

@espressif-bot espressif-bot added the Status: Opened Issue is new label Dec 12, 2023
@github-actions github-actions bot changed the title Provide ulp_adc_deinit() API to fix ADC1 handle leakage Provide ulp_adc_deinit() API to fix ADC1 handle leakage (IDFGH-11673) Dec 12, 2023
@ESP-Marius
Copy link
Collaborator

Thanks for adding this @kutukvpavel!

LGTM, i'll pull it into our internal gitlab for review, test and merge.

@ESP-Marius
Copy link
Collaborator

sha=8596d46774d65171b4540288918037c43e3debb4

@ESP-Marius ESP-Marius added the PR-Sync-Merge Pull request sync as merge commit label Dec 14, 2023
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Selected for Development Issue is selected for development labels Jan 12, 2024
@espressif-bot espressif-bot merged commit 8596d46 into espressif:master Jan 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants