Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing configuration for DEFAULT_ACCEPTMBOX_SIZE (fix #12509) (IDFGH-11364) #12510

Closed

Conversation

pguyot
Copy link
Contributor

@pguyot pguyot commented Nov 2, 2023

No description provided.

Copy link

github-actions bot commented Nov 2, 2023

Warnings
⚠️ The PR description looks very brief, please check if more details can be added.

👋 Welcome pguyot, thank you for your first contribution to espressif/esp-idf project!

📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project.

Pull request review and merge process you can expect

Espressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved, we synchronize it into our internal git repository
  4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  5. If the change is approved and passes the tests it is merged into the master branch
  6. On next sync from the internal git repository merged change will appear in this public Github repository

🔁 You can re-run automatic PR checks by retrying the DangerJS action

Generated by 🚫 dangerJS against 00bb284

@espressif-bot espressif-bot added the Status: Opened Issue is new label Nov 2, 2023
@github-actions github-actions bot changed the title Add missing configuration for DEFAULT_ACCEPTMBOX_SIZE (fix #12509) Add missing configuration for DEFAULT_ACCEPTMBOX_SIZE (fix #12509) (IDFGH-11364) Nov 2, 2023
@espressif-bot espressif-bot added Status: In Progress Work is in progress Status: Reviewing Issue is being reviewed Status: Done Issue is done internally Resolution: Duplicate This issue or pull request already exists and removed Status: Opened Issue is new Status: In Progress Work is in progress Status: Reviewing Issue is being reviewed labels Jan 19, 2024
@Alvin1Zhang
Copy link
Collaborator

Thanks for contribution again, changes have been merged with 336c094.

@pguyot pguyot deleted the w44/add-CONFIG_LWIP_ACCEPTMBOX_SIZE branch February 19, 2024 19:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Duplicate This issue or pull request already exists Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants