Make export.fish exit with SUCCESS exit code (IDFGH-9460) #10828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The export.fish script exits with an exit code of 4. Thus, any shell checks that make sure the source command exits successfully always failed. This was due to the last line trying to erase the __main function. In fish, you can't erase a function using the `set` command, you can only erase variables. By removing that line the script now exits with an exit code of 0 instead of 4.
|
|
github-actions
bot
changed the title
Remove the unused `unset` function in export.fish. The author of the script decided to simply use `set -e` instead so the function was never used
|
Thanks for your contribution. |
espressif-bot
added
Status: In Progress
|
@maxslarsson Thanks for your contribution! On the other hand, I had to remove you commit Remove unused unset function in export.fish. This function is used when users are switching from one ESP-IDF version to another in opened terminal. One of subcommand in export script then generate sequence of commands with keyword |
|
Ahh I see! Thank you for letting me know and for taking the time to review my changes. Let me know if I can do anything else! |
espressif-bot
added
Resolution: NA
espressif-bot
pushed a commit
that referenced
this pull request
Mar 19, 2023
The export.fish script exits with an exit code of 4. Thus, any shell checks that make sure the source command exits successfully always failed. This was due to the last line trying to erase the __main function. In fish, you can't erase a function using the `set` command, you can only erase variables. By removing that line the script now exits with an exit code of 0 instead of 4. Erase __main function at the end of export.fish Closes #10828
espressif-bot
pushed a commit
that referenced
this pull request
Mar 20, 2023
The export.fish script exits with an exit code of 4. Thus, any shell checks that make sure the source command exits successfully always failed. This was due to the last line trying to erase the __main function. In fish, you can't erase a function using the `set` command, you can only erase variables. By removing that line the script now exits with an exit code of 0 instead of 4. Erase __main function at the end of export.fish Closes #10828
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The export.fish script currently exits with an exit code of 4. Thus, any checks that make sure the
sourcecommand exited successfully (exit code equal to zero) always fail. This was due to the last line trying to erase the__mainfunction using theset -ecommand. In fish, you can only erase variables using thesetcommand. By changing the last line to erase the__mainfunction with thefunctions -ecommand, the script now exits with an exit code of 0 instead of 4.Also, while looking at the script, I noticed that the
unsetfunction seemed to be unused. My understanding was that the author of the script opted to directly use theset -ecommand in the script instead of theunsetfunction, leaving it unused.