[AES] Timeout: return error dont abort (IDFGH-9265) #10648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
precommit hitting some internal error:
|
github-actions
bot
changed the title
|
Thanks for your contribution. |
ESP-Marius
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
LGTM @chipweinberger, ill pull the PR into our internal gitlab for a full round of CI.
The precommit/poetry issue has already been fixed internally, and should be available on github with the next sync.
|
sha=91ab4b55137510b7267d8f442c7165754edc472f |
espressif-bot
added
Status: In Progress
espressif-bot
added
Resolution: NA
|
The xSemaphoreTake timeout is changed, but the commit log did not mentation the reason for this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10647
Replace abort with an error.
"Fundamental problems" should not be happening on consumer devices, but yet they are...
I don't see any downside to an error code here.