Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp_lcd: panel_io_i80_tx_color without cmd (IDFGH-9426) #10794

Closed
mcbp223 opened this issue Feb 18, 2023 · 0 comments
Closed

esp_lcd: panel_io_i80_tx_color without cmd (IDFGH-9426) #10794

mcbp223 opened this issue Feb 18, 2023 · 0 comments
Assignees
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally Type: Feature Request Feature request for IDF

Comments

@mcbp223
Copy link

mcbp223 commented Feb 18, 2023

Is your feature request related to a problem?

This is the same request as in #10302 and #9881, but for the i80 bus instead of SPI.
For panel_io_i80_tx_param and panel_io_i80_tx_color don't send cmd if the parameter is negative.

I have tried in lcd_start_transaction(...) with

    uint32_t cmd_cycles = trans_desc->cmd_cycles;
    if (trans_desc->cmd_value < 0) {
        cmd_cycles = 0;
    } else {
        lcd_ll_set_command(bus->hal.dev, bus->bus_width, trans_desc->cmd_value);
    }
    lcd_ll_set_phase_cycles(bus->hal.dev, cmd_cycles, 0, trans_desc->data ? 1 : 0);

It does skip the command, but there seems to appear a moirée pattern over the image, like a regular grid of dots, or vertical lines that appear like xor, or data bus not ready for a pixel, maybe some timing is off, so it would need some more testing. The geometry of the image stays correct.

Describe the solution you'd like.

No response

Describe alternatives you've considered.

No response

Additional context.

No response

@mcbp223 mcbp223 added the Type: Feature Request Feature request for IDF label Feb 18, 2023
@github-actions github-actions bot changed the title esp_lcd: panel_io_i80_tx_color without cmd esp_lcd: panel_io_i80_tx_color without cmd (IDFGH-9426) Feb 18, 2023
@espressif-bot espressif-bot added the Status: Opened Issue is new label Feb 18, 2023
@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Apr 3, 2023
@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: In Progress Work is in progress Status: Reviewing Issue is being reviewed Resolution: NA Issue resolution is unavailable labels Apr 4, 2023
espressif-bot pushed a commit that referenced this issue Apr 8, 2023
espressif-bot pushed a commit that referenced this issue May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally Type: Feature Request Feature request for IDF
Projects
None yet
Development

No branches or pull requests

3 participants