Skip to content

Commit

Permalink
Merge branch 'support/esp_coredump_logs_config_v4.4' into 'release/v4.4'
Browse files Browse the repository at this point in the history
Optionally disable logs in espcoredump component (v4.4)

See merge request espressif/esp-idf!24484
  • Loading branch information
mahavirj committed Jul 7, 2023
2 parents 5efdd24 + 6516e34 commit 962621e
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 13 deletions.
8 changes: 8 additions & 0 deletions components/espcoredump/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,14 @@ menu "Core dump"
help
Enables/disable core dump module.

config ESP_COREDUMP_LOGS
bool "Enable coredump logs for debugging"
depends on ESP_COREDUMP_ENABLE
default y
help
Enable/disable coredump logs. Logs strings from espcoredump component are
placed in DRAM. Disabling these helps to save ~5KB of internal memory.

config ESP_COREDUMP_MAX_TASKS_NUM
int "Maximum number of tasks"
depends on ESP_COREDUMP_ENABLE
Expand Down
24 changes: 11 additions & 13 deletions components/espcoredump/include_core_dump/esp_core_dump_types.h
Original file line number Diff line number Diff line change
@@ -1,16 +1,9 @@
// Copyright 2015-2019 Espressif Systems (Shanghai) PTE LTD
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at

// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
/*
* SPDX-FileCopyrightText: 2015-2023 Espressif Systems (Shanghai) CO LTD
*
* SPDX-License-Identifier: Apache-2.0
*/

#ifndef ESP_CORE_DUMP_PRIV_H_
#define ESP_CORE_DUMP_PRIV_H_

Expand All @@ -26,7 +19,12 @@ extern "C" {
#include "esp_private/panic_internal.h"
#include "core_dump_checksum.h"

#if CONFIG_ESP_COREDUMP_LOGS
#define ESP_COREDUMP_LOG( level, format, ... ) if (LOG_LOCAL_LEVEL >= level) { esp_rom_printf(DRAM_STR(format), esp_log_early_timestamp(), (const char *)TAG, ##__VA_ARGS__); }
#else
#define ESP_COREDUMP_LOG( level, format, ... ) // dummy define doing nothing
#endif

#define ESP_COREDUMP_LOGE( format, ... ) ESP_COREDUMP_LOG(ESP_LOG_ERROR, LOG_FORMAT(E, format), ##__VA_ARGS__)
#define ESP_COREDUMP_LOGW( format, ... ) ESP_COREDUMP_LOG(ESP_LOG_WARN, LOG_FORMAT(W, format), ##__VA_ARGS__)
#define ESP_COREDUMP_LOGI( format, ... ) ESP_COREDUMP_LOG(ESP_LOG_INFO, LOG_FORMAT(I, format), ##__VA_ARGS__)
Expand Down
1 change: 1 addition & 0 deletions docs/en/api-guides/performance/ram-usage.rst
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ To minimize static memory use:

- Declare structures, buffers, or other variables ``const`` whenever possible. Constant data can be stored in flash not RAM. This may require changing functions in the firmware to take ``const *`` arguments instead of mutable pointer arguments. These changes can also reduce the stack usage of some functions.
:SOC_BT_SUPPORTED: - If using Bluedroid, setting the option :ref:`CONFIG_BT_BLE_DYNAMIC_ENV_MEMORY` will cause Bluedroid to allocate memory on initialization and free it on deinitialization. This doesn't necessarily reduce the peak memory usage, but changes it from static memory usage to runtime memory usage.
- If :doc:`Coredump </api-guides/core_dump>` component is enabled, `ESP_COREDUMP_LOG` macros will use ~5KB internal memory to place strings into DRAM. By disabling :ref:`CONFIG_ESP_COREDUMP_LOGS` option, these logs are disabled and the memory is reclaimed.

.. _optimize-stack-sizes:

Expand Down

0 comments on commit 962621e

Please sign in to comment.