Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build examples and tests with -Werror (BSP-176) #51

Open
1 of 2 tasks
igrr opened this issue Aug 5, 2022 · 1 comment
Open
1 of 2 tasks

Build examples and tests with -Werror (BSP-176) #51

igrr opened this issue Aug 5, 2022 · 1 comment
Assignees
Labels
Area: Example Relates to example Resolution: Awaiting response Issue is awaiting response from author Type: Feature Request New feature or request

Comments

@igrr
Copy link
Member

igrr commented Aug 5, 2022

To make sure that the examples can be built without warnings, we should export EXTRA_CFLAGS and EXTRA_CXXFLAGS variables in CI before running idf.py build.

Here's a snippet from IDF:

export PEDANTIC_FLAGS="-DIDF_CI_BUILD -Werror -Werror=deprecated-declarations -Werror=unused-variable -Werror=unused-but-set-variable -Werror=unused-function"
export PEDANTIC_CFLAGS="${PEDANTIC_FLAGS} -Wstrict-prototypes"
export PEDANTIC_CXXFLAGS="${PEDANTIC_FLAGS}"
export EXTRA_CFLAGS=${PEDANTIC_CFLAGS}
export EXTRA_CXXFLAGS=${PEDANTIC_CXXFLAGS}

(IDF build system picks up EXTRA_CFLAGS and EXTRA_CXXFLAGS environment variables)

  • Test app pedantic flags
  • Examples pedantic flags
@igrr igrr added the Type: Feature Request New feature or request label Aug 5, 2022
@github-actions github-actions bot changed the title Build examples and tests with -Werror Build examples and tests with -Werror (BSP-176) Aug 5, 2022
@tore-espressif tore-espressif self-assigned this Sep 7, 2022
tore-espressif added a commit that referenced this issue Sep 7, 2022
tore-espressif added a commit that referenced this issue Sep 7, 2022
@VojtechBartoska VojtechBartoska added the Area: Example Relates to example label Mar 13, 2024
@VojtechBartoska
Copy link
Contributor

@tore-espressif there have been 2 PRs merged, can this issue be closed as solved? Thanks

@VojtechBartoska VojtechBartoska added the Resolution: Awaiting response Issue is awaiting response from author label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Example Relates to example Resolution: Awaiting response Issue is awaiting response from author Type: Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants