-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New OpenThread CLI Arduino Library for ESP32-C6 and ESP32-H2 #9908
Conversation
👋 Hello SuGlider, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 56 files 56 suites 9m 37s ⏱️ For more details on these failures, see this check. Results for commit 81d62e9. ♻️ This comment has been updated with latest results. |
@lucasssvaz - Is it possible that the CI failures are related to using cached files that don't have the necessary file structure? |
@SuGlider Also you have to fix the Arduino as IDF component as CI is failing for C6 and H2.
|
Openthread is already an IDF component. When I use Arduino as Component, I clone IDF repository with all submodules, recursively and this error never happens. |
@SuGlider I suggest you guard the library files with #include "sdkconfig.h"
#if CONFIG_OPENTHREAD_ENABLED
#include "esp_openthread.h"
//...
#endif /* CONFIG_OPENTHREAD_ENABLED */ |
but it's not enabled in the default CI build. That's it's purpose |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Fixes the documentation first paragraph in order to make it easier fore reading. It also displays in the very top which SoC are supported by the library.
@P-R-O-C-H-Y - DangerJS Linter fails... Is it a problem? DangerJS checks (rules) output states: Commit messages style......................................................................... Failed |
@SuGlider The DangerJS failure is bc some of the wokwi tests failed |
But all passed, only DangerJS failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid putting everything in a single line
@lucasssvaz - I have added more commented lines in the array. I think that it should get all in the right place. Could youforce running the formatting CI job on top of the current PR just to check if it changes anything else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SuGlider Yeah, looks good.
@me-no-dev - I guess that the PR is ready for merging. Please check if there is something else missing beside the Wokwi CI errors. |
Description of Change
Adds the OpenThread CLI Arduino Library.
It has some examples.
Only available for the C6 and H2.
Tests scenarios
Examples tested on C6 and H2.
Related links