-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deep Sleep Example Fix #9904
Deep Sleep Example Fix #9904
Conversation
Fixes the Deep Sleep wakup example to run with IDF5.1. The API has changed and a adjustment was necessary.
Changed the example to use a #define for the RTC IO Pin (GPIO) used in the example.
Test Results 56 files 56 suites 5m 18s ⏱️ Results for commit d367d39. ♻️ This comment has been updated with latest results. |
👋 Hello SuGlider, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
libraries/ESP32/examples/DeepSleep/ExternalWakeUp/ExternalWakeUp.ino
Outdated
Show resolved
Hide resolved
Fixes the commentary to the correct IDF terms.
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Is that actually correct? With ESP-IDF 5.0.4, it is still esp_sleep_enable_ext1_wakeup() With ESP-IDF 5.1.4, it is still esp_sleep_enable_ext1_wakeup() Whereas ESP-IDF 5.2.x introduces esp_sleep_enable_ext1_wakeup_io(), but esp_sleep_enable_ext1_wakeup() is nonetheless still present, but with a depreciation notice for v6. This is also the case for the "release-v5.1" documentation. |
Arduino 3.0.x is based on IDF 5.1.x exclusively. |
Exactly... which is why this PR seems incorrect... 🤦 it is using 5.2.x syntax, not 5.1.x syntax. |
Ok, thanks for pointing that out. Any idea what is actually different between the two, as I was expecting 5.1.4 to be the latest release for 5.1, not this |
Maybe the documentation for 5.1.4 is incomplete. |
Thanks @pfeerick for and investigation. I guess we can keep the PR. Please let me know if you have any other disagreement. |
Description of Change
IDF 5.1 has changed the way how RTC IO shall be configured in order to make it work as Wakeup source.
This PR fixes the example to work within Arduino Core 3.0.x that uses IDF 5.1.
Tests scenarios
Using ESP32 + the example provided. Tested using EXT0 and EXT1.
Related links
Closes #9809