-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variant for Elecrow CrowPanel 7.0" #9897
Conversation
Add variant for Elecrow CrowPanel 7.0"
Add variant for Elecrow CrowPanel 7.0"
👋 Hello lboue, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Just a heads up, you dont need to close and open a new PR to update your files. Just push to the base branch that the pull request refers to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lboue Just small nitpicks ptal. Otherwise looking good.
Elecrow CrowPanel 7.0" has 4MB flash
It sould be OK with my last commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist
This entire section above can be deleted if all items are checked.
Description of Change
Add variant for Elecrow CrowPanel 7.0"
Variant for https://www.elecrow.com/esp32-display-7-inch-hmi-display-rgb-tft-lcd-touch-screen-support-lvgl.html
Tests scenarios
I have tested my Pull Request on Arduino-esp32 core 3.0.1 with Elecrow CrowPanel 7.0" with this scenario.
Related links
Fixes: #9895