-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdmmc): Add RAW disk functions #9796
Conversation
👋 Hello lbernstone, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 56 files 56 suites 4m 17s ⏱️ Results for commit c92bd43. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
feat(sdmmc): fixed printf mismatches and missing callback feat(sdmmc): added ci.json Removed excess log_i
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If someone has a S3 rig set up able to do 4-bit SDIO, I'd be interested to know what kind of transfer rate you can get vs 1-bit. |
* feat(sdmmc): Add RAW disk functions feat(sdmmc): fixed printf mismatches and missing callback feat(sdmmc): added ci.json Removed excess log_i * ci(pre-commit): Apply automatic fixes * Fixed sdmmc host check to pass CI * feat(sdmmc): fixed example USB check --------- Co-authored-by: lbernstone <lbernstone@gmail.com> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
Description of Change
Added SD_MMC.ReadRAW and SD_MMC.WriteRAW. Added example to demonstrate USBMSC accessing SDMMC card.
Tests scenarios
Tested on ESP32-S3 (the only supported platform ATM), v3.0.0