fix(boards): Remove duplicate VID/PID from boards.txt and add default CDC/JTAG board #9717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a hidden board with the default VID/PID of USB CDC/JTAG in order to always show that in IDE when ESP32 CDC/JTAG device is connected
👋 Hello me-no-dev, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
|
@P-R-O-C-H-Y we need to enforce that this VID/PID combo is not added to other boards |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
me-no-dev
commented
May 29, 2024
| @@ -38,6 +38,8 @@ esp32_family.name=ESP32 Family Device | |||
| esp32_family.hide=true | |||
| esp32_family.vid.0=0x303a | |||
| esp32_family.pid.0=0x1001 | |||
| esp32_family.upload_port.0.vid=0x303a | |||
| esp32_family.upload_port.0.pid=0x1001 | |||
There was a problem hiding this comment.
@ladyada in order for discovery to work properly with IDE2 and CLI, it is necessary to add the .upload_port lines. Maybe someone there can update your board definitions?
cc: @UnexpectedMaker
There was a problem hiding this comment.
thanks
@hathach can you add to your ToDo list :)
@me-no-dev is there a date you need this by?
There was a problem hiding this comment.
@ladyada we plan on pushing bugfix releases fairly often, so it's not a hurry.
There was a problem hiding this comment.
@ladyada sure, I will follow this up
P-R-O-C-H-Y
approved these changes
May 29, 2024
|
Hey @me-no-dev - Thanks for pinging me as well... So you mean we need to add this to each of our boards, using the same PID/VID as the board? |
Yes. First two lines are for IDE1 and second lines are for IDE2 and CLI |
|
Wicked, thanks, doing a PR now :) |
1 task
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a hidden board with the default VID/PID of USB CDC/JTAG in order to always show that in IDE when ESP32 CDC/JTAG device is connected and removes all other mentions of that VID/PID