Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Additional Adafruit boards including the new Qualia ESP32-S3 and Camera ESP32-S3 #8696

Merged
merged 30 commits into from
Oct 4, 2023

Conversation

makermelissa
Copy link
Contributor

Description of Change

Adds Additional Adafruit boards including the new Qualia ESP32-S3 and Camera ESP32-S3

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.

(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)

Related links

Please provide links to related issue, PRs etc.

(eg. Closes #number of issue)

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makermelissa PTAL on my comments.

variants/adafruit_camera_esp32s3/pins_arduino.h Outdated Show resolved Hide resolved
variants/adafruit_qualia_s3_rgb666/pins_arduino.h Outdated Show resolved Hide resolved
boards.txt Outdated
Comment on lines 12128 to 12130

# Adafruit Qualia ESP32-S3 RGB666

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing line of # to separate boards

Suggested change
# Adafruit Qualia ESP32-S3 RGB666
##############################################################
# Adafruit Qualia ESP32-S3 RGB666

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed that one @ladyada ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm i see the change in the PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, they showed up now... maybe GH is a bit slow

@P-R-O-C-H-Y
Copy link
Member

@ladyada @makermelissa Can you please take a look on my comments quickly? We are preparing 2.0.14 release right now. Thanks

@ladyada
Copy link
Contributor

ladyada commented Oct 4, 2023

lookin!

ladyada and others added 4 commits October 4, 2023 11:57
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
@ladyada
Copy link
Contributor

ladyada commented Oct 4, 2023

ok i believe all were done. if i can have another 10 minutes i have another silly fix i have to make (i used OPI PSRAM pins on a board and turns out you cant do that :D )

@me-no-dev
Copy link
Member

@ladyada you can have another 10 😆

@ladyada
Copy link
Contributor

ladyada commented Oct 4, 2023

(doing last hardware tests...)

@ladyada
Copy link
Contributor

ladyada commented Oct 4, 2023

ok done, for real! srsly! no backies

@me-no-dev
Copy link
Member

You still got time till the CI is done ;)

@ladyada
Copy link
Contributor

ladyada commented Oct 4, 2023

nah i think we're good now, lots of fun hardware and now it even works right ;)

@me-no-dev me-no-dev merged commit a0b5a09 into espressif:master Oct 4, 2023
35 checks passed
@ladyada
Copy link
Contributor

ladyada commented Nov 4, 2023

@me-no-dev woops this actually got reverted in a '5.1' update script

https://github.com/espressif/arduino-esp32/blame/master/variants/adafruit_metro_esp32s3/pins_arduino.h#L56

ill resubmit a new PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants