Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Board name change (ETBoard -> ET-Board) #4858

Merged
merged 16 commits into from
Mar 8, 2021
Merged

Board name change (ETBoard -> ET-Board) #4858

merged 16 commits into from
Mar 8, 2021

Conversation

ketri2484
Copy link
Contributor

ETBoard -> ET-Board

@me-no-dev
Copy link
Member

this looks like board was added, not changed

@ketri2484
Copy link
Contributor Author

this looks like board was added, not changed

I changed 'boards.txt' file.
It changed ETBoard to ET-board.
Check please.

@me-no-dev
Copy link
Member

if you have changed the board, then the old one would have been shown as deleted. it seems you only added lines to the file, not deleting the old ones.

@me-no-dev
Copy link
Member

now it looks proper. please check the pins for SDA and SCL. seems they have been changed

@me-no-dev me-no-dev changed the title Board name changed. Board name change (ETBoard -> ET-Board) Mar 4, 2021
@ketri2484
Copy link
Contributor Author

now it looks proper. please check the pins for SDA and SCL. seems they have been changed

Thank you.
It is correct to change pins for SDA and SCL.

@me-no-dev
Copy link
Member

what are the correct I2C pins though? 21 an 22?

@ketri2484
Copy link
Contributor Author

ketri2484 commented Mar 8, 2021

what are the correct I2C pins though? 21 an 22?

SDA is pin 21.
SCL is pin 22.

@me-no-dev me-no-dev merged commit 7dc769d into espressif:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants