-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new device: Elecrow 5.0inch esp32 display #812
Add new device: Elecrow 5.0inch esp32 display #812
Conversation
✅ Deploy Preview for esphome-devices ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried this out and it doesn't work. 🙈
- The lvgl image configurations are invalid as they do not have a
src
. - Dont use the
esp32s3box
, use the genericesp32-s3-devkitc-1
Example configurations should not have secrets and passwords and should not make any assumptions about data that may or may not be available.
It is fine to have an lvgl example in here, but maybe it could be a bit more useful with buttons etc to show the touch working.
You should not add extra "soft" sensors like uptime, wifi info etc. Only hardware sensors present on a board should be included.
If you want a 1s
update interval for the counter, use the interval
component.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hi. Thanks for the feedback. For lvgl part I did include the official example I got from the manufacturer. But I agree with you that it was too complicated and partially incorrect, so I made own example with one button and one meter. |
I have been following this merge because I'm using a slight variation of the Elecrow display. I was just able to get the LVGL version of the example code working with one exception - the 3 power_meter_input_img's are not defined in the example. I got it working by commenting out the "- image:" sections of each but it would be nice if this part of the example was fixed so we could see what it's supposed to look like. |
@sprior Sorry, I do not follow. I did change the lvgl example based on @jesserockz feedback 2 days ago - it does not contain the 3 images you mention. |
@bruxy70 Ok thanks, I was looking at the version on the website, didn't see the fixed version. I'm working with the MaTouch ESP32-S3 Parallel TFT with Touch 7“ (1024x600) board which so far I've got working with:
And uses different pins for I2C: |
@bruxy70 I just noticed that in the latest version of your index.md file you still mention esp32s3box up in the top Drivers section. |
Thanks. I missed that one. Fixed. The examples are tested and working, so I hope it should now be ready to go? |
The status says change requested. But I made the changes. What do I have to update to update the status? |
Nothing. Someone (if not me) will come back around when time permits =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes/simplifications.
Compiled and installed this yaml as is and working nicely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor capitalisation and spelling
5-inch 800*480 resolution LCD display with ESP32 S3 microcontroller
Including the minimal configuration.
Plus a more extensive example provided by Elecrow technician for the video I am making (don't want to keep it for myself).
With the reference to Elecrow wiki with all parameters.