NodeMCU v1.0 board option "Builtin Led" define overrides variant define

[erdemuncuoglu]

Fixes #6904

[d-a-v]

In recent version, nodeMCU has an arduino IDE menu option to chose which LED is the BUILTIN_LED. Did you see it ?

With PlatformIO, you need to add LED_BUILTIN definition in your local settings.

I'm sorry to say we can't merge your proposed change.

[d-a-v]

Reference: #6748 and #4715

[erdemuncuoglu]

I'm neither using Arduino IDE nor PlatformIO but I was exactly trying to say that #6748 is buggy (at least in Sloeber).
My PR is a fix not a duplicate addition. Maybe I am weak at explaining it.
Can you review it again please?
Thanks.

PS: My nodeMCU has two leds on it one is on pin 2 located on module other is on pin 16 located on board.

[erdemuncuoglu]

Sorry accidentally pressed that request review button.

[d-a-v]

@erdemuncuoglu #6748 was indeed borked.
Your changes also fixed nodemcu v1 with Arduino IDE defining pin 16 for builtin led.
Thanks ! 👍

[robrey]

I am using an ESP8266 nodemcu to read RFID tags with the RC522 and sends to another ESP8266 nodemcu via WiFi. I used the LED_BUILTIN to debug the system and I connected the pin D4 (GPIO2, IO2, pin 17) to recieve the IRQ signal from RC522. In this connection the LED_BUILTIN didn't work. At the end, I decided to free the pin D4 and I declared IRQ pin D2, after this change LED_BUILTIN began to work. My advice is: If you want to use the LED_BUITIN of the ESP8266 nodemcu, do not use pin D4 at all.