Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CI - no need to list every embassy_* example explicitly #900

Closed
wants to merge 12 commits into from

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Nov 3, 2023

It's easy to forget to add an example to CI (I always forget that) - so instead of checking each embassy_* example separately use --example=embassy*. That means we need to follow the convention of prefixing embassy examples with embassy_ which we already do

This might result in checking some examples multiple times (we do that already) I guess it's better for maintenance

Also, this changes from check to build to also verify the linker step

Some examples had other problems which are fixed, too

@bjoernQ bjoernQ added the skip-changelog No changelog modification needed label Nov 3, 2023
@bjoernQ bjoernQ marked this pull request as draft November 3, 2023 08:45
@bjoernQ bjoernQ marked this pull request as ready for review November 3, 2023 11:21
@bjoernQ
Copy link
Contributor Author

bjoernQ commented Nov 3, 2023

Not sure if we really want this. I especially don't like the naming convention for the Xtensa examples needing the embassy-executor-interrupt

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Jan 15, 2024

Given the lack of activity here and the fact that CI might need a more radical rewrite .... closing this

I still think we need a more fool-proof way of checking examples ideally without listing them in the CI workflow

@bjoernQ bjoernQ closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant