Pin static_cell #899
Merged
Pin static_cell #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the future can we please add comments when we do this? I don't like pinning dependencies, and if there isn't a rationale given there is a good chance I will remove the |
|
Sure, sorry about that. In this case, if you accidentally remove it, CI will either scream at you for it or we will live in a happier future where portable-atomic works and we won't need pinning static_cell anyway. |
|
ah true .... but you will quickly remember when you do and CI starts to build 🤣 |
katyo
pushed a commit
to katyo/esp-hal
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static_cell 1.3 was released yesterday dropping atomic-polyfill in favour of portable-atomic. Unfortunately, portable-atomic isn't compatible with something in RISC-V atomic emulation. This PR pins the old version as a band-aid so CI can stay blissfully ignorant.
Xtensa targets should be fine without this PR but I've pinned those to stay consistent with RV.