Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3: Fix the number of GPIO pins #898

Merged
merged 1 commit into from
Nov 3, 2023
Merged

S3: Fix the number of GPIO pins #898

merged 1 commit into from
Nov 3, 2023

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Nov 3, 2023 •
edited

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

Fixes #897

Pins are numbered 0..48, with some numbers missing in the middle. Using GPIO_NUM = 48 meant that this array had one fewer element than required.

@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 3, 2023

portable-atomic, again 😞

bjoernQ
bjoernQ approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjoernQ bjoernQ merged commit 111d006 into esp-rs:main Nov 3, 2023
17 checks passed
@bugadani bugadani deleted the gpio branch November 3, 2023 07:27
katyo pushed a commit to katyo/esp-hal that referenced this pull request Nov 6, 2023
@bugadani @katyo
S3: Fix the number of GPIO pins (esp-rs#898)
0f8cf1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GPIO number should be 49 not 48 for ESP32-S3
2 participants
@bugadani @bjoernQ