Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32-C6/H2: UART sync registers and use xtal #893

Merged
merged 2 commits into from
Nov 1, 2023
Merged

ESP32-C6/H2: UART sync registers and use xtal #893

merged 2 commits into from
Nov 1, 2023

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Nov 1, 2023

Fixes #892

MabezDev
MabezDev approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably refactor these cfg's away at some point, there must be a better way to abstract over this.

but for now, LGTM!

@bjoernQ bjoernQ merged commit a13ab29 into esp-rs:main Nov 1, 2023
17 checks passed
@bjoernQ bjoernQ deleted the fix/esp32c6-esp32h2-uart-baudrate branch November 1, 2023 14:58
katyo pushed a commit to katyo/esp-hal that referenced this pull request Nov 6, 2023
@bjoernQ @katyo
ESP32-C6/H2: UART sync registers and use xtal (esp-rs#893)
c46813b 
* ESP32-C6/H2: UART sync registers and use xtal

* CHANGELOG.md entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESP32-C6 / ESP32-H2: UART baud-rate wrong
2 participants
@bjoernQ @MabezDev