-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async read implementation for usb serial jtag #889
Conversation
Thanks for the PR, apologies for taking so long to get to this! I will try to get this tested and reviewed in the next couple days. |
I needed to rebase this branch in order to get it building, however after doing so it seems to be working as expected! So, if you wouldn't mind rebasing (there is unfortunately a conflict with Additionally, if you're willing to add examples for the other chips that would be great, but I can do so in a subsequent PR so it's not huge deal. |
a48201e
to
9835c8a
Compare
Ok, I've added examples for all c6, h2, and s3 (basically all the ones that already had a non-embassy usb_serial_jtag example). They're untested, though, because I don't have any of them. I also took the liberty of removing the scary comment from s3's usb_serial_jtag example because that issue is fixed, apparently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks again for this!
This is an attempt at adding an async read implementation for usb_serial_jtag to complement the existing async write implementation. I'm pretty unsure about whether I'm doing the interrupt handling correctly, but I did at least check that a basic implementation works.
errors
orwarnings
.cargo fmt
was run.CHANGELOG.md
in the proper section.Nice to have