Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new clippy lints introduced in 1.78 & 1.79 #1776

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

MabezDev
Copy link
Member

@MabezDev MabezDev commented Jul 9, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

@MabezDev MabezDev added the skip-changelog No changelog modification needed label Jul 9, 2024
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@SergioGasquez
Copy link
Member

HIL builds for S2 and S3 are failing due to changes in the Xtensa Rust toolchain (older versions do not fail) and seems to be something in the semihosting crate

Copy link
Contributor

@playfulFence playfulFence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking care of this that fast!

@MabezDev
Copy link
Member Author

MabezDev commented Jul 9, 2024

Hmm, I can't repro locally 🤔

@jessebraham
Copy link
Member

jessebraham commented Jul 9, 2024

I'm able to reproduce the errors locally, seem to originate from the semihosting@0.1.11 release. Adding the following patch to hil-test/Cargo.toml:

[patch.crates-io]
semihosting = { git = "https://github.com/taiki-e/semihosting", tag = "v0.1.10" }

... and then running cargo update from within the package's directory results in a successful build on my end.

@jessebraham
Copy link
Member

FYI I've opened an issue upstream for this: taiki-e/semihosting#11

@jessebraham jessebraham added this pull request to the merge queue Jul 9, 2024
Merged via the queue into esp-rs:main with commit e75d43d Jul 9, 2024
30 checks passed
@MabezDev MabezDev deleted the fix-clippy branch July 9, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants