Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HUB75 example using lcd_cam #1684

Closed
wants to merge 7 commits into from

Conversation

liebman
Copy link
Contributor

@liebman liebman commented Jun 15, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

I'm (ab)using the lcd peripheral to drive a hub75e led matrix and found that after a send is complete line are all set low. I need one of the pins to remain high between calls.

Description

I've added a "with_options(invert_bits) to the TxEightBits and TxSixteenBits implementations to allow any/all bits to be set to inverted. Also consolidated the pin configuration into a macro as its 24 of almost the same code.

Testing

Run on an esp32s3 and reviewed logic analyzer output.

@liebman liebman force-pushed the lcd-i8080-add-invert-pin-option branch from 59d3772 to d0bf3a9 Compare June 18, 2024 20:57
@liebman liebman changed the title lcd_cam: add pin invert option to i8080 HUB75 experiments: lcd_cam Jun 21, 2024
@liebman liebman force-pushed the lcd-i8080-add-invert-pin-option branch from 764d294 to d72a4c4 Compare July 6, 2024 17:08
@liebman
Copy link
Contributor Author

liebman commented Jul 6, 2024

I'm still struggling on how to make the pins optional to TxSixteenBits and TxEightBits. I think this is useful as is. The example shows how to display on a HUB75 display using the lcd_cam peripheral. If someone has ideas on making pins optional here I'm all ears.

@liebman liebman marked this pull request as ready for review July 6, 2024 18:12
@liebman liebman changed the title HUB75 experiments: lcd_cam HUB75 example using lcd_cam Jul 6, 2024
@liebman liebman marked this pull request as draft July 7, 2024 12:27
@liebman
Copy link
Contributor Author

liebman commented Jul 7, 2024

So AnyPin::new_inverted() works and helms with issues of the type signature. Closing - with create a separate PR with the example.

@liebman liebman closed this Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant