Make software interrupts shareable #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
I think this is a good idea!
I think I made a mistake with changing the Alarm methods from systimer to &mut in #1455 , I didn't consider the usability of doing so. Luckily we're developing a better general timer API in #1479 so we can fix that there :D.
This should be safe because each software interrupt is a singleton, meaning only one of each can exist anyway and in this case modifications are atomic/stateless (just plain register write with no side effects). In other words calling these methods reentrantly would never result in bad state/memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
My immediate use case for this is #1476 where I want to be able to
raise()the interrupt from any core.It feels silly to have to pull out a
RefCellorMutexjust to ultimately toggle a volatile register.I think it makes sense for this to be shareable within Rust rules. Exclusive access can still be achieved with a mutable reference.
Testing
CI