Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an xtask subcommand for building documentation #1160

Merged
merged 5 commits into from
Feb 13, 2024

Conversation

jessebraham
Copy link
Member

Additionally fixes a silly mistake I made in the first PR (which I had fixed locally, but forgotten to commit 😅)

@jessebraham jessebraham added the skip-changelog No changelog modification needed label Feb 12, 2024
@jessebraham
Copy link
Member Author

jessebraham commented Feb 12, 2024

Oh hold up, need to fix something quickly...

Should be good to go now.

@jessebraham
Copy link
Member Author

I'm actually going to add some more functionality as well (in-progress), so will draft this until I'm ready.

@jessebraham jessebraham marked this pull request as draft February 12, 2024 18:55
@jessebraham jessebraham marked this pull request as ready for review February 13, 2024 17:30
@jessebraham
Copy link
Member Author

jessebraham commented Feb 13, 2024

Okay this should be good to go now, I think (for real this time).

@jessebraham
Copy link
Member Author

Also I will actually write a proper README.md for it one day, I just don't want to document things while they're still in flux.

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The xtask automation looks very sweet! Thanks for assembling it

@jessebraham jessebraham added this pull request to the merge queue Feb 13, 2024
Merged via the queue into esp-rs:main with commit 2b8db5c Feb 13, 2024
17 checks passed
@jessebraham jessebraham deleted the feature/xtask branch February 14, 2024 14:00
@jessebraham jessebraham mentioned this pull request Feb 15, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants