RngCore trait is implemented
#1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
playfulFence
force-pushed
the
rng_traits
branch
from
4e87fc0
to
f41b871
Compare
|
(Sorry, attached the wrong issue by mistake) |
JurajSadel
reviewed
Jan 29, 2024
There was a problem hiding this comment.
LGTM, thank you! I can see a warning:
warning: unused import: `Error`
--> /home/runner/work/esp-hal/esp-hal/esp-hal-common/src/rng.rs:68:17
|
68 | use rand_core::{Error, RngCore};
| ^^^^^
|
= note: `#[warn(unused_imports)]` on by defaultAgain, we have a bunch of others as well but it would be nice to try to avoid introducing new ones :D
Changelog entry Get rid of warning
playfulFence
force-pushed
the
rng_traits
branch
from
f41b871
to
a51cf9a
Compare
|
@JurajSadel |
playfulFence
added a commit
to playfulFence/esp-hal
that referenced
this pull request
Jan 30, 2024
* WIP made randomness ensuring function implemented RngCore trait (final version i guess) * Revert part of changes and leave TODO comment Changelog entry Get rid of warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on this task it turned out that we do not provide true randomness of generated numbers yet (our generator is not TRNG yet), which does not allow us to implement
CryptoRngmarker trait for our structure yet. The #1120 was created due to that.For now I left the
TODOinstead of implementing CryptoRng. When #1120 will be closed, we'll replace TODO with implementation of a marker trait.Also not sure if this PR should close the initial #942, to be discussed.