Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add callout box for unintuitive behavior #18567

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

benmccann
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

closes #18562

I found this behavior to be very surprising and numerous maintainers also agreed in #17213

Is there anything you'd like reviewers to focus on?

I don't know if there are other callout boxes you use besides "important". I saw that used on another page, so used the same one, but perhaps there's a more appropriate one?

@benmccann benmccann requested a review from a team as a code owner June 6, 2024 15:44
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jun 6, 2024
Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit ce9b061
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6661d9495e8fcf00081c35a5
😎 Deploy Preview https://deploy-preview-18567--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough. LGTM.

@nzakas nzakas merged commit 9ce6832 into eslint:main Jun 6, 2024
19 of 20 checks passed
@benmccann benmccann deleted the patch-1 branch June 6, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to ESLint's documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Change Request: align global and non-global ignores
2 participants