Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update WebdriverIO packages #18558

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

christian-bromann
Copy link
Contributor

@christian-bromann christian-bromann commented Jun 5, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Fixes #18548

What changes did you make? (Give an overview)

I update the WebdriverIO packages for browser tests to pass again more reliable. WebdriverIO has released v8.38.3 which fixes some performance issues we've discovered with some changes introduced to the test harness in Eslint.

Is there anything you'd like reviewers to focus on?

@christian-bromann christian-bromann requested a review from a team as a code owner June 5, 2024 03:17
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Jun 5, 2024
Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 2051e6a
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6668f8c481ceec00089c0796

Comment on lines +110 to +114
"@wdio/browser-runner": "^8.38.3",
"@wdio/cli": "^8.38.2",
"@wdio/concise-reporter": "^8.38.2",
"@wdio/globals": "^8.38.2",
"@wdio/mocha-framework": "^8.38.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, but the browser tests are still failing. Reference

@aladdin-add
Copy link
Member

@nzakas
Copy link
Member

nzakas commented Jun 7, 2024

@christian-bromann it looks like this is still failing, can you take a look?

@christian-bromann
Copy link
Contributor Author

@nzakas @aladdin-add not sure why it was failing but I don't see them failing anymore.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's try this since the tests often fail with pinned 8.36.0 anyway.

@mdjermanovic mdjermanovic merged commit 1495b93 into eslint:main Jun 12, 2024
19 checks passed
@christian-bromann christian-bromann deleted the cb/wdio-update branch June 12, 2024 06:47
@christian-bromann
Copy link
Contributor Author

Please keep me posted if failures pop up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore This change is not user-facing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ci: browser testing is failing sometimes
5 participants