Fix incorrect range calculation for operator rem
#7610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acf3116 enhanced the range calculation for `rem`, but at the same time introduced a bug. For example: 2 rem X If the range for `X` was unknown, the compiler would calculate the range for the remainder as `{2,2}`, while the correct range is `{0,2}`. This commit corrects the range calculation for the remainder to ensure that zero is always included in the range.
bjorng
added
team:VM
sverker
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acf3116 enhanced the range calculation for
rem, but at the same time introduced a bug. For example:If the range for
Xwas unknown, the compiler would calculate the range for the remainder as{2,2}, while the correct range is{0,2}. This commit corrects the range calculation for the remainder to ensure that zero is always included in the range.