Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dialyzer failures in CI #7231

Merged
merged 1 commit into from
May 29, 2023
Merged

Fix Dialyzer failures in CI #7231

merged 1 commit into from
May 29, 2023

Conversation

TD5
Copy link
Contributor

@TD5 TD5 commented May 15, 2023

Dialyzer failed in CI during testing because we'd run the tests in a Docker image which uses the output of a build of OTP, but that build doesn't include the scripts/ directory (which contains the script for running Dialyzer) from the main Git repository. This change mirrors that directory into the Docker image used for testing so that it can be run there.

Tested by running the GitHub Actions on my own fork.

Dialyzer failed in CI during testing because we'd run the tests in a Docker image which uses the output of a build of OTP, but that build doesn't include the `scripts/` directory (which contains the script for running Dialyzer) from the main Git repository. This change mirrors that directory into the Docker image used for testing so that it can be run there.
@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2023

CT Test Results

    1 files    11 suites   4m 50s ⏱️
  93 tests   91 ✔️ 2 💤 0
109 runs  107 ✔️ 2 💤 0

Results for commit 3a099f8.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@rickard-green rickard-green added the team:VM Assigned to OTP team VM label May 15, 2023
@bjorng bjorng changed the base branch from master to maint May 29, 2023 13:09
@bjorng bjorng merged commit 194b100 into erlang:maint May 29, 2023
@bjorng
Copy link
Contributor

bjorng commented May 29, 2023

Thanks for your pull request.

I changed the base to maint before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:VM Assigned to OTP team VM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants