beam_ssa_type: Don't filter out literals in meet_types/2 #6582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhogberg
added
team:VM
jhogberg
force-pushed
the
john/compiler/infer_relops-singleton-bug/GH-6568
branch
from
c12d60c
to
df80f8e
Compare
We can't skip meeting literals since we may have to bail out when the result is 'none'. We still don't need to store the result however.
jhogberg
force-pushed
the
john/compiler/infer_relops-singleton-bug/GH-6568
branch
from
df80f8e
to
b9eb167
Compare
CT Test Results 2 files 285 suites 13m 12s ⏱️ Results for commit b9eb167. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
bjorng
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't skip meeting literals since we may have to bail out when the result is 'none'. We still don't need to store the result however.
Fixes #6578
Fixes #6568