[erlc] internal error in pass beam_validator_strong

[RobinMorisset]

Describe the bug
Running erlc on the following:

f(Y, X) ->
    fun(X) ->
        <<Y:(abs(ceil(-1.0 = X)))/float, (binary_to_integer(ok))>>,
        ceil(X) band Y
    end.

results in the following error message:

Function: '-f/2-fun-0-'/2
/home/rmorisset/minimized/validator.erl: internal error in pass beam_validator_strong:
exception error: no match of right hand side value false
  in function  beam_validator:unpack_typed_arg/2 (beam_validator.erl, line 2833)
  in call from beam_validator:'-vi/2-lc$^20/1-9-'/2 (beam_validator.erl, line 754)
  in call from beam_validator:vi/2 (beam_validator.erl, line 754)
  in call from beam_validator:validate_instrs/4 (beam_validator.erl, line 333)
  in call from beam_validator:validate_1/5 (beam_validator.erl, line 276)
  in call from beam_validator:validate_0/4 (beam_validator.erl, line 114)
  in call from beam_validator:validate/2 (beam_validator.erl, line 56)
  in call from compile:beam_validator_1/3 (compile.erl, line 1682)

Affected versions
master

[RobinMorisset]

commit 039c5de (from #7157) changes the error message to:

validator:1: function '-f/2-fun-0-'/2+14:
  Internal consistency check failed - please report this bug.
  Instruction: {gc_bif,'band',
                       {f,0},
                       0,
                       [{tr,{y,0},{t_integer,any}},{integer,-1}],
                       {x,0}}
  Error:       {bad_typed_register,{t_float,any},{t_integer,any}}:

[jhogberg]

039c5de is a drive-by fix for better error reporting in this case, the crash is the same.

@bjorng has a fix in the works :-)

[bjorng]

The linked pull request fixes the bugs for OTP 26. The fix will also be released in a patch for OTP 25.