Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update marauder companion to 0.7.1 #49

Closed
wants to merge 1 commit into from

Conversation

runcom
Copy link
Contributor

@runcom runcom commented Jun 4, 2024

This is based on #48 - let me know if you want them together but I think it's cleaner like this

@runcom runcom marked this pull request as draft June 4, 2024 23:04
@eried
Copy link
Owner

eried commented Jun 5, 2024

Awesome! thanks

@eried
Copy link
Owner

eried commented Jun 5, 2024

(I think is fine as is now, I will test on the weekend and let you know)

@runcom
Copy link
Contributor Author

runcom commented Jun 5, 2024

(I think is fine as is now, I will test on the weekend and let you know)

awesome, I've rebased and tested on my fz and it seems to work just fine, I'll do more testing over the weekend too

@runcom runcom force-pushed the update-marauder-companion branch from a7ddb66 to ca8f335 Compare June 5, 2024 08:08
@runcom runcom marked this pull request as ready for review June 5, 2024 08:09
@runcom
Copy link
Contributor Author

runcom commented Jun 5, 2024

ready and I haven't disabled wardrive here - so I'm gonna close #47 in favor of this and we keep the discussion on that enablement here

Yeah, I am not sure, what do you suggest for this kind of "optional" features?

I think it could just work like it does with justcallmekoko's marauder - you build the functionality in and it's left to the user to install a GPS 🤷 if they select wardrive and there's no gps, since there are HAS_GPS ifdefs, worst case it doesn't log gps data right?

@runcom runcom mentioned this pull request Jun 5, 2024
@runcom runcom force-pushed the update-marauder-companion branch 2 times, most recently from 5dffc07 to 26e625c Compare June 8, 2024 18:54
@runcom
Copy link
Contributor Author

runcom commented Jun 8, 2024

new push fixes baudrate for FZ, ufbt compilation and add back the camera option to take pics with marauder directly

@runcom
Copy link
Contributor Author

runcom commented Jun 8, 2024

also, the wardrive functionality works paired with my other PR and gps setup :) you get the wardrive log file with gps info too :)

@runcom runcom force-pushed the update-marauder-companion branch 2 times, most recently from b0faad8 to fd5d308 Compare June 9, 2024 15:32
Signed-off-by: Antonio Murdaca <antoniomurdaca@gmail.com>
@runcom runcom force-pushed the update-marauder-companion branch from fd5d308 to f437300 Compare June 9, 2024 15:48
@eried
Copy link
Owner

eried commented Jun 10, 2024

Thanks! I will test it tonight and merge :)

@eried
Copy link
Owner

eried commented Sep 2, 2024

I will directly update to 1.0, but I have some space problems

@eried eried closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants