Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix aliasing bug #12

Merged
merged 7 commits into from
Nov 19, 2023
Merged

fix aliasing bug #12

merged 7 commits into from
Nov 19, 2023

Conversation

ericphanson
Copy link
Owner

fixes #11

Also updates tests for latest Convex/MOI syntax, and adds tests that OT! on the same arguments works.

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2573b06) 99.29% compared to head (1359f33) 99.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   99.29%   99.39%   +0.09%     
==========================================
  Files           5        5              
  Lines         141      164      +23     
==========================================
+ Hits          140      163      +23     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericphanson
Copy link
Owner Author

Nightly failure is jump-dev/Convex.jl#512

@ericphanson ericphanson merged commit d4625b7 into master Nov 19, 2023
5 of 7 checks passed
@ericphanson ericphanson deleted the eph/investigate-bug branch November 19, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Likely correctness bug in sinkhorn_divergence for divergences other than KL
2 participants