Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use supports_add_constrained_variables #38

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

blegat
Copy link
Contributor

@blegat blegat commented Sep 3, 2020

supports_add_constrained_variables was introduced in a previous MOI release and it is now required to implement it rather than supports_constraint as the LazyBridgeOptimizer now assumes that this is implemented by solvers.
This is a breaking change for solvers (not for users). We shouldn't really have included it in a non-breaking MOI release but we've chosen the approach of introducing the new function in an early release to leave the time for solvers to transition. Now is the time as MOI v0.9.15 will start requiring the solvers to have tranitioned.
This PR does the transition.

@ericphanson
Copy link
Owner

ericphanson commented Sep 3, 2020

Thanks very much for the PR!

Looking at the CI logs,

@blegat
Copy link
Contributor Author

blegat commented Sep 3, 2020

It looks like though there are also MOI unsupported errors for things that didn't throw before

I just updated the commit, this should fix this.

@ericphanson
Copy link
Owner

looks good, thanks!

@ericphanson ericphanson merged commit 4fdcad7 into ericphanson:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants