This repository has been archived by the owner on Jan 25, 2024. It is now read-only.
Finished getOrder, started working on scheduled, fixed issue #95 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull from Eric Blade
Product info update
pwrnrd
changed the title
|
Thanks for the changes! codebeat is complaining about the length of your sample, not a big deal. Coveralls is weird -- it has my credentials saved, it should use them when anyone pushes, but it looks like it only uses them when a commit is from me . . . so what's the point of storing them and making them hidden? shrug So there's not really a big drop in coverage. LGTM, merging. |
|
Cool thanks! If you have any tips / feedback for me, please let me know! Then I can improve the code further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added GetOrder: updated tests, added basic documentation, added wrapper
Worked on scheduled reports. Did NOT write tests/documentation. We need to start working on the issues mentioned by @ericblade in ./lib/reports.js. These issues lead reports to be cancelled. I also found that some reports return "DONE_NO_DATA" when I know for sure that there is data available. The latter issue, the "DONE_NO_DATA" issue looks similar to the following issue posted on the seller central forum: https://sellercentral.amazon.com/forums/t/always-getting--done-no-data--for--get-flat-file-orders-data-/409592 .
Fixed issue #95.