Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to select channels from several logs and show them all in one view #2152 #2379

Merged
merged 28 commits into from
May 3, 2024
Merged

Ability to select channels from several logs and show them all in one view #2152 #2379

merged 28 commits into from
May 3, 2024

Conversation

robertbasti
Copy link
Collaborator

@robertbasti robertbasti commented Apr 24, 2024 •
edited
Loading

Fixes

This pull request fixes #2152

Description

  • user is able to view mnemonics from several logs in one view

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Desktop
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

@eliasbruvik eliasbruvik marked this pull request as draft April 26, 2024 07:06
@robertbasti robertbasti marked this pull request as ready for review April 26, 2024 10:06
eliasbruvik
eliasbruvik requested changes Apr 29, 2024
View reviewed changes
Src/WitsmlExplorer.Api/Models/LogCurveInfo.cs Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Api/Models/LogData.cs Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Frontend/routes/Router.tsx Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Api/Routes.cs Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Api/Services/LogObjectService.cs Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Frontend/components/ContextMenus/LogCurveInfoContextMenu.tsx Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Frontend/hooks/useGetActiveRoute.tsx Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Frontend/services/logObjectService.tsx Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Frontend/services/logObjectService.tsx Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Frontend/hooks/query/useGetSeveralLogsMnemonics.tsx Outdated Show resolved Hide resolved
janmarius
janmarius approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@janmarius janmarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer checklist

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@robertbasti robertbasti merged commit d4bdfc2 into equinor:main May 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janmarius janmarius janmarius approved these changes

@eliasbruvik eliasbruvik eliasbruvik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to select channels from several logs and show them all in one view
3 participants
@robertbasti @janmarius @eliasbruvik