Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job view crashes for jobs with many report items #2311 #2327

Merged
merged 19 commits into from
Mar 22, 2024

Conversation

robertbasti
Copy link
Collaborator

Fixes

This pull request fixes #2311

Description

  • job view does not crash while displaying big reports
  • data of big reports are downloading directly by clicking "Download file" link in jobs view
  • a new api function for fetching report data created
  • report data removed from job view for big reports

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • [] New code is covered by passing tests

Further comments

Copy link
Contributor

@eliasbruvik eliasbruvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly looked at the API, and suggested some improvements. I will review the frontend when it's changed according to the updated endpoints.

Src/WitsmlExplorer.Api/HttpHandlers/JobHandler.cs Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Api/Services/JobCache.cs Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Api/Models/Reports/BaseReport.cs Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Api/Workers/DownloadAllLogDataWorker.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@eliasbruvik eliasbruvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@robertbasti robertbasti merged commit 71599f7 into equinor:main Mar 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job view crashes for jobs with many report items🐛
2 participants