-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-2296 Add generic Button component #2309
Merged
janmarius
merged 15 commits into
equinor:main
from
janmarius:FIX-2296-one-button-component
Mar 18, 2024
Merged
FIX-2296 Add generic Button component #2309
janmarius
merged 15 commits into
equinor:main
from
janmarius:FIX-2296-one-button-component
Mar 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tton from modal dialog
eliasbruvik
requested changes
Mar 18, 2024
Src/WitsmlExplorer.Frontend/components/ContentViews/table/ColumnOptionsMenu.tsx
Outdated
Show resolved
Hide resolved
Src/WitsmlExplorer.Frontend/components/Modals/TrimLogObject/AdjustDateTimeModal.tsx
Outdated
Show resolved
Hide resolved
eliasbruvik
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Read issue and PR
- Pulled branch and manually tested
- Verify that PR resolves issue
- Reviewed the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This pull request fixes #2296
Description
This PR will add a generic Button component to be used throughout the application instead of using different styled EDSButton components at various places.
This PR will not move the buttons listed below:
IconButton
used inColumnDev.tsx
ReportButton
inJobsView
. Please note that this is a styleddiv
.ConnectButton
inServerManager.tsx
as it has unique styling.Upload File
button inLogDataImportModal.tsx
will not be changed due toEDSButton
not supporting upload windows out of the box.Button.Group
will also not be changed in this PR. A separate issue will be created to add support for this.Type of change
Impacted Areas in Application
Checklist:
Communication
Code quality
Test coverage
Further comments