Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-2296 Add generic Button component #2309

Merged
merged 15 commits into from
Mar 18, 2024

Conversation

janmarius
Copy link
Contributor

Fixes

This pull request fixes #2296

Description

This PR will add a generic Button component to be used throughout the application instead of using different styled EDSButton components at various places.

This PR will not move the buttons listed below:

  • The IconButton used in ColumnDev.tsx
  • The ReportButton in JobsView. Please note that this is a styled div.
  • The ConnectButton in ServerManager.tsx as it has unique styling.
  • The Upload File button in LogDataImportModal.tsx will not be changed due to EDSButton not supporting upload windows out of the box.
  • Buttons using Button.Group will also not be changed in this PR. A separate issue will be created to add support for this.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

Copy link
Contributor

@eliasbruvik eliasbruvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@janmarius janmarius merged commit 8a8b280 into equinor:main Mar 18, 2024
3 checks passed
@janmarius janmarius deleted the FIX-2296-one-button-component branch March 18, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add one styled component for buttons
2 participants