Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-2227 make it not possible to add duplicated prioritized log curves #2228

Merged
merged 1 commit into from
Feb 2, 2024
Merged

FIX-2227 make it not possible to add duplicated prioritized log curves #2228

merged 1 commit into from
Feb 2, 2024

Conversation

janmarius
Copy link
Contributor

Fixes

This pull request fixes #2227

Description

Disabled 'Add Priority Log Curve' button if log curve already exists or is empty to avoid adding empty or duplicate log curves.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

eliasbruvik
eliasbruvik approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@eliasbruvik eliasbruvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@janmarius janmarius merged commit ed3d393 into equinor:main Feb 2, 2024
3 checks passed
@janmarius janmarius deleted the FIX-2227-duplicate-prirotiy-log-curve branch February 6, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliasbruvik eliasbruvik eliasbruvik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛Currently it is possible to add a duplicate priority log curve.
2 participants
@janmarius @eliasbruvik