Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-2205 Fix copy log curve bugs #2221

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

eliasbruvik
Copy link
Contributor

@eliasbruvik eliasbruvik commented Jan 26, 2024

Fixes

This pull request fixes #2205 and #2191

Description

Fixed these bugs:

  • Error when using "CopyToServer" if you include the indexCurve.
  • LogCurveInfo properties are not copied if the target curve already exists.
  • LogCurveInfo properties are not copied if using "Copy with range to server", and the curve is outside the selected range.

New behavior:

  • If using "CopyToServer" with the indexCurve, it won't attempt to delete it.
  • The LogCurveInfo object is always copied for selected curves, even if the target LogCurveInfo object already exists, and even if it's not within the specified range.
  • When copying the index curve, properties other than uid and mnemonic in the LogCurveinfo object will be copied, even if the names of the index curves does not match. The uid and mnemonic of index curves can not be changed for a log.

Note for the reviewer:
The removed Assert in the test was removed as for this test there are no "existing" mnemonics to copy. Before I ensured that the target log had the correct mnemonic and uid of the indexCurve LogCurveInfo object, the worker added it as an existing mnemonic. As we do not have any existing mnemonics, there is one less call to UpdateInStore.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

@eliasbruvik eliasbruvik merged commit f923f94 into equinor:main Feb 2, 2024
4 checks passed
@eliasbruvik eliasbruvik deleted the FIX-2205-copyBugs branch February 2, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy log curve does not copy LogCurveInfo properties to existing LogCurveInfo objects🐛
2 participants