Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicities #2044 #2171

Merged
merged 7 commits into from
Dec 4, 2023
Merged

Remove duplicities #2044 #2171

merged 7 commits into from
Dec 4, 2023

Conversation

petrlicman
Copy link
Collaborator

Fixes

This pull request fixes #2044

Description

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

janmarius
janmarius suggested changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@janmarius janmarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait with merge.

@petrlicman petrlicman requested review from janmarius and removed request for janmarius December 4, 2023 08:29
janmarius
janmarius reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@janmarius janmarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge now.

@petrlicman petrlicman merged commit 9fd3008 into equinor:main Dec 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janmarius janmarius janmarius approved these changes

@vaclavbasniar vaclavbasniar vaclavbasniar approved these changes

@robertbasti robertbasti Awaiting requested review from robertbasti

@jaroslavbliznak jaroslavbliznak Awaiting requested review from jaroslavbliznak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove duplicities in code
3 participants
@petrlicman @janmarius @vaclavbasniar