Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use webpack conditional loader for resolving addon-redux dependency #856

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

shadab-skhan
Copy link
Contributor

Current changes is failing published storybook as static sb is built using production flag.
Hence using webpack-conditional-loader

@shadab-skhan shadab-skhan added bug Something isn't working AspenTech Task owned by AspenTech map-component Issues related to the map component. labels Feb 28, 2022
@shadab-skhan shadab-skhan self-assigned this Feb 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2022

Codecov Report

Merging #856 (12c3cb7) into master (da0e5f8) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
- Coverage   73.19%   73.10%   -0.10%     
==========================================
  Files          74       74              
  Lines        1791     1785       -6     
  Branches      289      286       -3     
==========================================
- Hits         1311     1305       -6     
  Misses        460      460              
  Partials       20       20              
Impacted Files Coverage Δ
react/src/lib/components/DeckGLMap/redux/store.ts 100.00% <100.00%> (ø)
react/src/lib/components/GroupTree/redux/store.ts 100.00% <100.00%> (ø)
.../src/lib/components/WellCompletions/redux/store.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da0e5f8...12c3cb7. Read the comment docs.

@shadab-skhan shadab-skhan merged commit 0f5593c into equinor:master Feb 28, 2022
@shadab-skhan shadab-skhan deleted the webpackloader branch April 13, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AspenTech Task owned by AspenTech bug Something isn't working map-component Issues related to the map component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NGRM] - using addon-redux enforces dependency on @storybook in production
3 participants