Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all the needed files in the npm package #498

Merged
merged 7 commits into from
Aug 16, 2021

Conversation

alexandruandrei91
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2021

Codecov Report

Merging #498 (ba8907b) into master (8813d77) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #498   +/-   ##
=======================================
  Coverage   71.37%   71.37%           
=======================================
  Files          53       53           
  Lines        1090     1090           
  Branches      142      142           
=======================================
  Hits          778      778           
  Misses        294      294           
  Partials       18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8813d77...ba8907b. Read the comment docs.

@alexandruandrei91 alexandruandrei91 self-assigned this Aug 16, 2021
@alexandruandrei91 alexandruandrei91 added AspenTech Task owned by AspenTech maintenance labels Aug 16, 2021
@alexandruandrei91 alexandruandrei91 marked this pull request as ready for review August 16, 2021 12:23
@alexandruandrei91 alexandruandrei91 merged commit c08d398 into equinor:master Aug 16, 2021
@alexandruandrei91 alexandruandrei91 deleted the npm-package-fix branch August 16, 2021 12:48
@anders-kiaer
Copy link
Collaborator

anders-kiaer commented Aug 16, 2021

@alexandruandrei91 Should I do an alpha release now?

- name: 🔼 Build and publish Node.js package
if: github.event_name == 'release' && matrix.python-version == '3.6'
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
working-directory: ./react
run: |
cp ../README.md .
npm version --no-git-tag-version ${GITHUB_REF//refs\/tags\//}
npm config set '//registry.npmjs.org/:_authToken' '${NPM_TOKEN}'
npm config set always-auth true
# Use 'latest' tag if $NPM_PUBLISH_TAG is not set:
npm publish --access public --tag ${NPM_PUBLISH_TAG:-latest}
and
- name: 🏗️ Build JavaScript part
run: |
npm run build --prefix ./react
can be as is (i.e. no change in npm commands to run)?

@alexandruandrei91
Copy link
Contributor Author

@anders-kiaer Yes, the commands should remain the same. It would be good to try an alpha release, to see how it goes :). I've tried locally with npm pack after setting the version and it seems to work ok.

hkfb pushed a commit to hkfb/webviz-subsurface-components that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AspenTech Task owned by AspenTech maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants