Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fusion/issues/285 #1781

Merged
merged 5 commits into from
Feb 2, 2024
Merged

Fusion/issues/285 #1781

merged 5 commits into from
Feb 2, 2024

Conversation

odinr
Copy link
Collaborator

@odinr odinr commented Feb 1, 2024

Why

@equinor/fusion-framework-app - minor

removed useFeatureFlags from AppConfigurator since caused issued for users without installing feature-flag module

Caution

breaking changes: assumes no one has implemented this yet

@equinor/fusion-framework-react-app - patch

Added functionality for enabling feature flagging

import { enableFeatureFlag } from `@equinor/fusion-framework-react-app/feature-flag`
enableFeatureFlag(confgurator, [{
  id: 'my-flag',
  title: 'My flag'
}])

the user still needs to install @equinor/fusion-framework-module-feature-flag

Check off the following:

  • Confirm that I checked changes to branch which I am merging into.

    • I have validated included files
    • My code does not generate new linting warnings
    • My PR is not a duplicate, check existing pr`s
  • Confirm that the I have completed the self-review checklist.

  • Confirm that my changes meet our code of conduct.

Conditional

  • Confirm project selected and category, actual, iteration are set
  • Confirm Milestone selected (if any)

caused issued for users without installing feature-flag module

BREAKING CHANGE: we assume few if any has implemented this configuration
Copy link

changeset-bot bot commented Feb 1, 2024

🦋 Changeset detected

Latest commit: ce5e102

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@equinor/fusion-framework-react-app Patch
@equinor/fusion-framework-app Minor
@equinor/fusion-framework-cookbook-app-react-feature-flag Patch
@equinor/fusion-framework-legacy-interopt Major
@equinor/fusion-framework-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@odinr odinr self-assigned this Feb 1, 2024
@github-actions github-actions bot added 🐞 bug Something isn't working 👨🏻‍🍳 cookbooks 👾 React 📚 documentation Improvements or additions to documentation 🚀 feature New feature or request 🚧 chore maintaines work, (update deps, workflos ...) 🧨 breaking changes labels Feb 1, 2024
@odinr odinr marked this pull request as ready for review February 1, 2024 14:52
@odinr odinr requested a review from a team as a code owner February 1, 2024 14:52
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 4.8% 1288 / 26805
🔵 Statements 4.8% 1288 / 26805
🔵 Functions 5.98% 41 / 685
🔵 Branches 14.5% 106 / 731
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
cookbooks/app-react-feature-flag/src/config.ts 0% 0% 0% 0% 1-34
packages/app/src/AppConfigurator.ts 0% 0% 0% 0% 1-129
packages/react/app/src/feature-flag/enable-feature-flag.ts 0% 0% 0% 0% 1-76
packages/react/app/src/feature-flag/index.ts 0% 0% 0% 0% 1-9
Generated in workflow #3967

@odinr odinr merged commit 0f3affa into main Feb 2, 2024
14 checks passed
@odinr odinr deleted the fusion/issues/285 branch February 2, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧨 breaking changes 🐞 bug Something isn't working 🚧 chore maintaines work, (update deps, workflos ...) 👨🏻‍🍳 cookbooks 📚 documentation Improvements or additions to documentation 🚀 feature New feature or request 👾 React
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants