-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fusion/issues/285 #1781
Merged
Merged
Fusion/issues/285 #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caused issued for users without installing feature-flag module BREAKING CHANGE: we assume few if any has implemented this configuration
🦋 Changeset detectedLatest commit: ce5e102 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
🐞 bug
Something isn't working
👨🏻🍳 cookbooks
👾 React
📚 documentation
Improvements or additions to documentation
🚀 feature
New feature or request
🚧 chore
maintaines work, (update deps, workflos ...)
🧨 breaking changes
labels
Feb 1, 2024
Coverage Report
File Coverage
|
eikeland
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🧨 breaking changes
🐞 bug
Something isn't working
🚧 chore
maintaines work, (update deps, workflos ...)
👨🏻🍳 cookbooks
📚 documentation
Improvements or additions to documentation
🚀 feature
New feature or request
👾 React
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
@equinor/fusion-framework-app - minor
removed
useFeatureFlags
fromAppConfigurator
since caused issued for users without installing feature-flag moduleCaution
breaking changes: assumes no one has implemented this yet
@equinor/fusion-framework-react-app - patch
Added functionality for enabling feature flagging
the user still needs to install
@equinor/fusion-framework-module-feature-flag
Check off the following:
Confirm that I checked changes to branch which I am merging into.
Confirm that the I have completed the self-review checklist.
Confirm that my changes meet our code of conduct.
Conditional